Open
Conversation
Click 8.1.8 through 8.3.0 have broken pager invocation for multi-argument PAGER values, which causes behave test failures. Fixed on pallets/click@7db1f20
meeuw
reviewed
Feb 19, 2026
| dependencies = [ | ||
| "pgspecial>=2.0.0", | ||
| "click >= 4.1,<8.1.8", | ||
| "click >= 8.3.1", |
Contributor
There was a problem hiding this comment.
Maybe try this?
Suggested change
| "click >= 8.3.1", | |
| "click >= 4.1,<8.3.2", |
Contributor
|
@stratakis thanks for your PR, I approved the CI tests. For anyone reading this, rationale can be found here:
|
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Feb 19, 2026
click 8.1.8-8.2.x had broken pager invocation for multi-argument PAGER values. click 8.3.1 includes the fix (pallets/click@7db1f20). Removes the defensive <8.1.8 upper bound. Ref: dbcli#1556 Made with ❤️ and 🤖 Claude
DiegoDAF
approved these changes
Feb 19, 2026
DiegoDAF
left a comment
DiegoDAF
left a comment
There was a problem hiding this comment.
Confirmed working. We've been running with click 8.3.1 on our fork with the full test suite passing (2759 tests).
The old <8.1.8 upper bound was a workaround for the broken pager in 8.1.8-8.2.x. This is the proper fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Click 8.1.8 through 8.3.0 have broken pager invocation for multi-argument PAGER values, which causes behave test failures.
Fixed on pallets/click@7db1f20
AUTHORSfile (or it's already there).